Page MenuHomePhabricator

Fixing an issue with the display of svn property diffs (at least in svn 1.7)
Needs ReviewPublic

Authored by jaydiablo on Mar 27 2014, 12:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 15, 7:44 PM
Unknown Object (File)
Sat, Dec 28, 4:53 PM
Unknown Object (File)
Sat, Dec 28, 3:52 PM
Unknown Object (File)
Sat, Dec 28, 3:48 PM
Unknown Object (File)
Fri, Dec 27, 5:17 PM
Unknown Object (File)
Dec 24 2024, 5:56 PM
Unknown Object (File)
Nov 30 2024, 10:55 AM
Unknown Object (File)
Nov 25 2024, 9:18 PM
Subscribers

Details

Summary

Fixes T4682. If SVN 1.7 is detected (using the prop_index var) making sure existing props are added to both old and new and only + get added to new and - to old. Added a test case for this as well that shows both adding and removing properties from svn:ignore.

Test Plan

New test case added, existing tests for this code pass. The one failure failed before code changes, so assume it doesn't pass in my environment, or not at all. Also tested in my local copy of Arcanist against the same diff that is in T4682.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures

Event Timeline

jaydiablo retitled this revision from to Fixing an issue with the display of svn property diffs (at least in svn 1.7).
jaydiablo updated this object.
jaydiablo edited the test plan for this revision. (Show Details)

Here's a screenshot of that same diff from T4682, but with this change in Arc:

Screen_Shot_2014-03-26_at_6.00.53_PM.png (212×1 px, 21 KB)