Paths

Table of Contentst

Differential D8600

Use ApplicationTransactions and CustomField to implement build steps
ClosedPublic
Actions

Authored by epriestley on Mar 23 2014, 5:57 PM.

Tags

None

Referenced Files

	F14058488: D8600.diff
	Sun, Nov 17, 12:36 PM

	F14007069: D8600.diff
	Mon, Oct 28, 11:00 PM

	F13992994: D8600.diff
	Tue, Oct 22, 8:00 PM

	F13992968: D8600.id.diff
	Tue, Oct 22, 7:52 PM

	F13992965: D8600.id20389.diff
	Tue, Oct 22, 7:51 PM

	F13992956: D8600.id20391.diff
	Tue, Oct 22, 7:48 PM

	F13992944: D8600.id20430.diff
	Tue, Oct 22, 7:45 PM

	F13984628: D8600.diff
	Sun, Oct 20, 2:40 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4602: Steps with fields of type BuildStepImplementation::SETTING_TYPE_BOOLEAN don't render correctly.
T1049: Implement Harbormaster

Commits

Restricted Diffusion Commit
rPa246c85c6b51: Use ApplicationTransactions and CustomField to implement build steps

Summary

Ref T1049. Fixes T4602. Moves all the funky field stuff to CustomField. Uses ApplicationTransactions to apply and record edits.

This makes "artifact" fields a little less nice (but still perfectly usable). With D8599, I think they're reasonable overall. We can improve this in the future.

All other field types are better (e.g., fixes weird bugs with "bool", fixes lots of weird behavior around required fields), and this gives us access to many new field types.

Test Plan

Made a bunch of step edits. Here's an example:

Screen_Shot_2014-03-23_at_10.40.30_AM.png (1×1 px, 194 KB)

Note that:

"Required" fields work correctly.
the transaction record is shown at the bottom of the page.

Diff Detail

Repository

Branch

harbor4

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php:47	XHP16	TODO Comment

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20389.Mar 23 2014, 5:57 PM

epriestley retitled this revision from to Use ApplicationTransactions and CustomField to implement build steps.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T1049: Implement Harbormaster, T4602: Steps with fields of type BuildStepImplementation::SETTING_TYPE_BOOLEAN don't render correctly..

Herald added a subscriber: epriestley.Mar 23 2014, 5:57 PM

Remove a stray validateSettings() call.

btrahan accepted this revision.Mar 25 2014, 8:19 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 25 2014, 8:19 PM

Closed by commit rPa246c85c6b51 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140321.harbor.1.bxaction.sql

21 lines

src/

__phutil_library_map__.php

15 lines

applications/

harbormaster/

controller/

HarbormasterStepEditController.php

127 lines

customfield/

HarbormasterBuildStepCoreCustomField.php

41 lines

HarbormasterBuildStepCustomField.php

6 lines

editor/

HarbormasterBuildStepEditor.php

6 lines

query/

HarbormasterBuildStepTransactionQuery.php

10 lines

step/

BuildStepImplementation.php

50 lines

CommandBuildStepImplementation.php

36 lines

HarbormasterHTTPRequestBuildStepImplementation.php

44 lines

LeaseHostBuildStepImplementation.php

31 lines

PublishFragmentBuildStepImplementation.php

36 lines

SleepBuildStepImplementation.php

23 lines

UploadArtifactBuildStepImplementation.php

51 lines

storage/

configuration/

HarbormasterBuildStep.php

26 lines

HarbormasterBuildStepTransaction.php

14 lines

worker/

HarbormasterTargetWorker.php

11 lines

maniphest/

field/

ManiphestConfiguredCustomField.php

2 lines

people/

customfield/

PhabricatorUserConfiguredCustomField.php

2 lines

project/

customfield/

PhabricatorProjectConfiguredCustomField.php

2 lines

PhabricatorProjectDescriptionField.php

2 lines

infrastructure/

customfield/

config/

PhabricatorCustomFieldConfigOptionType.php

7 lines

field/

PhabricatorCustomField.php

18 lines

standard/

PhabricatorStandardCustomField.php

11 lines

Diff 20391

resources/sql/autopatches/20140321.harbor.1.bxaction.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/harbormaster/controller/HarbormasterStepEditController.php

Loading...

src/applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php

Loading...

src/applications/harbormaster/customfield/HarbormasterBuildStepCustomField.php

Loading...

src/applications/harbormaster/editor/HarbormasterBuildStepEditor.php

Loading...

src/applications/harbormaster/query/HarbormasterBuildStepTransactionQuery.php

Loading...

src/applications/harbormaster/step/BuildStepImplementation.php

Loading...

src/applications/harbormaster/step/CommandBuildStepImplementation.php

Loading...

src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php

Loading...

src/applications/harbormaster/step/LeaseHostBuildStepImplementation.php

Loading...

src/applications/harbormaster/step/PublishFragmentBuildStepImplementation.php

Loading...

src/applications/harbormaster/step/SleepBuildStepImplementation.php

Loading...

src/applications/harbormaster/step/UploadArtifactBuildStepImplementation.php

Loading...

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php

Loading...

src/applications/harbormaster/storage/configuration/HarbormasterBuildStepTransaction.php

Loading...

src/applications/harbormaster/worker/HarbormasterTargetWorker.php

Loading...

src/applications/maniphest/field/ManiphestConfiguredCustomField.php

Loading...

src/applications/people/customfield/PhabricatorUserConfiguredCustomField.php

Loading...

src/applications/project/customfield/PhabricatorProjectConfiguredCustomField.php

Loading...

src/applications/project/customfield/PhabricatorProjectDescriptionField.php

Loading...

src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php

Loading...

src/infrastructure/customfield/field/PhabricatorCustomField.php

Loading...

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

Loading...