Page MenuHomePhabricator

Make Harbormaster input and output artifacts more explicit
ClosedPublic

Authored by epriestley on Mar 23 2014, 5:26 PM.

Details

Summary

Ref T1049. In Harbormaster, build steps may have various inputs (like a host they should run on) and outputs (like a reference to an uploaded file).

  • Currently, inputs aren't defined anywhere (except implicitly at runtime).
    • Instead, define inputs explicitly.
  • Currently, outputs are defined in a way that loses information when misconfigured (the keys will collide).
    • Instead, define inputs and outputs so they work whether a step is configured correctly or not.
  • Currently, there's no simple way to see a step's inputs and outputs.
    • Add some UI for this.
  • Currently, reordering steps has some surprising side effects.
    • Instead of invalidating steps after reordering them, validate them at display time and warn the user.
Test Plan


Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley retitled this revision from to Make Harbormaster input and output artifacts more explicit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

One thing this affects is that we no longer validate other fields on display. The next diff will fix this in a general way.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2014, 8:17 PM
epriestley updated this revision to Diff 20429.

Closed by commit rP72337dedaff9 (authored by @epriestley).