Page MenuHomePhabricator

Make Herald less ambitious about resolving repositories for revisions
ClosedPublic

Authored by epriestley on Mar 20 2014, 12:19 PM.
Tags
None
Referenced Files
F18369298: D8576.diff
Thu, Aug 28, 2:05 AM
F18107119: D8576.diff
Sun, Aug 10, 11:41 PM
F18102580: D8576.id20352.diff
Sat, Aug 9, 9:49 PM
F18098531: D8576.diff
Fri, Aug 8, 8:45 PM
F18088923: D8576.id20352.diff
Wed, Aug 6, 10:04 AM
F17930587: D8576.id20370.diff
Wed, Jul 30, 6:07 PM
F17853496: D8576.id.diff
Jul 27 2025, 1:58 PM
F17818753: D8576.id20370.diff
Jul 26 2025, 12:38 AM
Subscribers

Details

Summary

Fixes T4636. If a user manually deletes a "repository" setting from a revision, Herald attempts to resolve it. Instead, Herald should now just trust Differential. Generally, the new logic is:

  • When diffs are created, figure out repository information.
  • When revisions are updated, copy info from diffs.
  • Everywhere else, just trust the revision field.
Test Plan
  • Created revisions.
  • Used Herald to dry-run revisions before and after a manual edit to remove the repository setting.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Make Herald less ambitious about resolving repositories for revisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 20 2014, 8:16 PM
epriestley updated this revision to Diff 20370.

Closed by commit rP03c6bf0d0916 (authored by @epriestley).