Page MenuHomePhabricator

Support `git-format-patch` format in diff parser
ClosedPublic

Authored by epriestley on Mar 15 2014, 4:27 PM.
Tags
None
Referenced Files
F13182327: D8547.id20278.diff
Thu, May 9, 11:15 PM
F13182326: D8547.id20277.diff
Thu, May 9, 11:15 PM
F13182322: D8547.id.diff
Thu, May 9, 11:12 PM
F13182317: D8547.diff
Thu, May 9, 11:08 PM
F13178196: D8547.diff
Wed, May 8, 8:15 PM
Unknown Object (File)
Sat, May 4, 5:56 AM
Unknown Object (File)
Sat, Apr 27, 9:02 PM
Unknown Object (File)
Sat, Apr 27, 9:02 PM
Subscribers

Details

Summary

Fixes T4063. The git format-patch command produces a special header
and footer which we need to detect, strip, and parse.

Test Plan
  • Added and ran unit tests.
  • Submitted a diff with git format-patch HEAD^ --stdout | arc diff --raw.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Support `git-format-patch` format in diff parser.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 15 2014, 5:08 PM
epriestley updated this revision to Diff 20278.

Closed by commit rARC46fe94db9f8c (authored by @epriestley).