Page MenuHomePhabricator

Support `git-format-patch` format in diff parser
ClosedPublic

Authored by epriestley on Mar 15 2014, 4:27 PM.
Tags
None
Referenced Files
F22522800: D8547.diff
Sun, Sep 20, 8:14 PM
Unknown Object (File)
Sat, Sep 12, 11:22 PM
Unknown Object (File)
Mon, Aug 24, 12:49 PM
Unknown Object (File)
Aug 11 2026, 5:12 PM
Unknown Object (File)
Aug 9 2026, 7:19 PM
Unknown Object (File)
Aug 9 2026, 7:19 PM
Unknown Object (File)
Aug 9 2026, 10:58 AM
Unknown Object (File)
Jul 3 2026, 8:03 AM
Subscribers

Details

Summary

Fixes T4063. The git format-patch command produces a special header
and footer which we need to detect, strip, and parse.

Test Plan
  • Added and ran unit tests.
  • Submitted a diff with git format-patch HEAD^ --stdout | arc diff --raw.

Diff Detail

Repository
rARC Arcanist
Branch
formatpatch
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/parser/__tests__/diff/git-format-patch.gitdiff:21TXT9Trailing Whitespace at EOF
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Support `git-format-patch` format in diff parser.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 15 2014, 5:08 PM
epriestley updated this revision to Diff 20278.

Closed by commit rARC46fe94db9f8c (authored by @epriestley).