Paths

Table of Contentst

Differential D8547

Support `git-format-patch` format in diff parser
ClosedPublic
Actions

Authored by epriestley on Mar 15 2014, 4:27 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4063: Parse the output of `git format-patch`

Commits

rARC46fe94db9f8c: Support `git-format-patch` format in diff parser

Summary

Fixes T4063. The git format-patch command produces a special header
and footer which we need to detect, strip, and parse.

Test Plan

Added and ran unit tests.
Submitted a diff with git format-patch HEAD^ --stdout | arc diff --raw.

Diff Detail

Repository

rARC Arcanist

Branch

formatpatch

Lint

Lint Passed

Severity	Location	Code	Message
Auto-Fix	src/parser/__tests__/diff/git-format-patch.gitdiff:21	TXT9	Trailing Whitespace at EOF

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20277.Mar 15 2014, 4:27 PM

epriestley retitled this revision from to Support `git-format-patch` format in diff parser.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4063: Parse the output of `git format-patch`.

Herald added a subscriber: epriestley.Mar 15 2014, 4:27 PM

btrahan accepted this revision.Mar 15 2014, 5:08 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 15 2014, 5:08 PM

Closed by commit rARC46fe94db9f8c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

ArcanistDiffParser.php

62 lines

__tests__/

ArcanistDiffParserTestCase.php

14 lines

diff/

git-format-patch.gitdiff

21 lines

workflow/

ArcanistDiffWorkflow.php

1 line

Diff 20277

View Options

src/parser/ArcanistDiffParser.php

View Options

src/parser/tests/ArcanistDiffParserTestCase.php

View Options

src/parser/tests/diff/git-format-patch.gitdiff

View Options

src/workflow/ArcanistDiffWorkflow.php

Support `git-format-patch` format in diff parserClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 20277

src/parser/ArcanistDiffParser.php

src/parser/__tests__/ArcanistDiffParserTestCase.php

src/parser/__tests__/diff/git-format-patch.gitdiff

src/workflow/ArcanistDiffWorkflow.php

Support `git-format-patch` format in diff parser
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/tests/ArcanistDiffParserTestCase.php

src/parser/tests/diff/git-format-patch.gitdiff