Page MenuHomePhabricator

Support `git-format-patch` format in diff parser
ClosedPublic

Authored by epriestley on Mar 15 2014, 4:27 PM.
Tags
None
Referenced Files
F15416705: D8547.id20278.diff
Thu, Mar 20, 1:02 PM
F15414799: D8547.id20277.diff
Thu, Mar 20, 2:34 AM
F15336527: D8547.diff
Sat, Mar 8, 7:22 PM
Unknown Object (File)
Tue, Feb 25, 10:41 AM
Unknown Object (File)
Feb 17 2025, 1:18 AM
Unknown Object (File)
Feb 15 2025, 1:33 AM
Unknown Object (File)
Feb 15 2025, 1:33 AM
Unknown Object (File)
Feb 5 2025, 10:20 AM
Subscribers

Details

Summary

Fixes T4063. The git format-patch command produces a special header
and footer which we need to detect, strip, and parse.

Test Plan
  • Added and ran unit tests.
  • Submitted a diff with git format-patch HEAD^ --stdout | arc diff --raw.

Diff Detail

Repository
rARC Arcanist
Branch
formatpatch
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/parser/__tests__/diff/git-format-patch.gitdiff:21TXT9Trailing Whitespace at EOF
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Support `git-format-patch` format in diff parser.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 15 2014, 5:08 PM
epriestley updated this revision to Diff 20278.

Closed by commit rARC46fe94db9f8c (authored by @epriestley).