Page MenuHomePhabricator

Use viwer-based checks for application visibility when rendering home elements
ClosedPublic

Authored by epriestley on Mar 15 2014, 3:30 PM.
Tags
None
Referenced Files
F15473829: D8545.diff
Sun, Apr 6, 1:56 AM
F15472721: D8545.id20274.diff
Sat, Apr 5, 3:40 PM
F15470593: D8545.diff
Fri, Apr 4, 11:36 PM
F15456415: D8545.diff
Sun, Mar 30, 9:31 AM
F15361010: D8545.id20274.diff
Tue, Mar 11, 11:23 AM
F15361009: D8545.id20280.diff
Tue, Mar 11, 11:23 AM
Unknown Object (File)
Feb 24 2025, 11:36 AM
Unknown Object (File)
Feb 15 2025, 1:33 AM
Subscribers

Details

Summary

Fixes T4619. Currently, even if a viewer can't see Maniphest, they'll still see empty panels on the home page. These panels will always be empty so there's no real policy violation, but it's confusing.

Longer term, dashboards should fix this.

Test Plan

Viewed home page with a user with and without permissions on the apps.

Diff Detail

Repository
rP Phabricator
Branch
apppolicy
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley retitled this revision from to Use viwer-based checks for application visibility when rendering home elements.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 15 2014, 3:59 PM
epriestley updated this revision to Diff 20280.

Closed by commit rPb3b0ef3647e8 (authored by @epriestley).