Page MenuHomePhabricator

Always link to "#5" (not "#comment-5") for "T123#5"
ClosedPublic

Authored by epriestley on Mar 14 2014, 9:39 PM.
Tags
None
Referenced Files
F15410900: D8542.diff
Wed, Mar 19, 8:40 AM
F15410861: D8542.diff
Wed, Mar 19, 8:35 AM
F15410844: D8542.diff
Wed, Mar 19, 8:32 AM
F15410822: D8542.diff
Wed, Mar 19, 8:30 AM
F15410801: D8542.diff
Wed, Mar 19, 8:27 AM
F15410776: D8542.diff
Wed, Mar 19, 8:24 AM
F15410738: D8542.diff
Wed, Mar 19, 8:19 AM
F15410718: D8542.diff
Wed, Mar 19, 8:17 AM
Subscribers

Details

Summary

Fixes T3976. Long ago, some applications used "#comment-5" instead of "#5" for transaction/comment anchors. Now everything (I think?) uses "#5"; this is the style used by ApplicationTransactions.

This might break some very old, explcit T123#comment-5 links, or off-site links to the comment-N anchors, but all that stuff generally got renumbered when we migrated anyway and getting you to the right object is like 95% of the job.

Test Plan

Verified that T123#5 now links to #5.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Always link to "#5" (not "#comment-5") for "T123#5".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 9:43 PM
epriestley updated this revision to Diff 20269.

Closed by commit rP3bea0958dd31 (authored by @epriestley).