Page MenuHomePhabricator

Always link to "#5" (not "#comment-5") for "T123#5"
ClosedPublic

Authored by epriestley on Mar 14 2014, 9:39 PM.
Tags
None
Referenced Files
F17857740: D8542.id20267.diff
Sun, Jul 27, 6:51 PM
F17837159: D8542.id.diff
Sat, Jul 26, 5:02 PM
F17836970: D8542.id.diff
Sat, Jul 26, 4:46 PM
F17828495: D8542.id20269.diff
Sat, Jul 26, 9:16 AM
F17816381: D8542.id.diff
Fri, Jul 25, 10:42 PM
F17808527: D8542.diff
Fri, Jul 25, 4:03 PM
F17758429: D8542.id20267.diff
Tue, Jul 22, 5:16 PM
F17738299: D8542.diff
Sun, Jul 20, 11:22 PM
Subscribers

Details

Summary

Fixes T3976. Long ago, some applications used "#comment-5" instead of "#5" for transaction/comment anchors. Now everything (I think?) uses "#5"; this is the style used by ApplicationTransactions.

This might break some very old, explcit T123#comment-5 links, or off-site links to the comment-N anchors, but all that stuff generally got renumbered when we migrated anyway and getting you to the right object is like 95% of the job.

Test Plan

Verified that T123#5 now links to #5.

Diff Detail

Repository
rP Phabricator
Branch
linkcomment
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley retitled this revision from to Always link to "#5" (not "#comment-5") for "T123#5".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 9:43 PM
epriestley updated this revision to Diff 20269.

Closed by commit rP3bea0958dd31 (authored by @epriestley).