Page MenuHomePhabricator
Differential D8524

Make PhabricatorBotFeedNotificationHandler work with new PhabricatorApplicationTransactionFeedStory
ClosedPublic
Actions

Authored by dctrwatson on Mar 14 2014, 12:46 AM.
Tags
None
Referenced Files
F14066390: D8524.diff
Tue, Nov 19, 9:43 AM
F14052041: D8524.diff
Fri, Nov 15, 6:06 AM
F14039404: D8524.diff
Mon, Nov 11, 5:26 AM
F14025267: D8524.diff
Thu, Nov 7, 3:46 PM
F14003069: D8524.id20229.diff
Sat, Oct 26, 1:51 AM
F13993290: D8524.id20221.diff
Tue, Oct 22, 9:52 PM
F13992978: D8524.id.diff
Tue, Oct 22, 7:56 PM
F13986394: D8524.id20231.diff
Mon, Oct 21, 2:37 AM
View All Files
Subscribers
aran
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPa5f6e19dfd66: Make PhabricatorBotFeedNotificationHandler work with new…
Summary

Depends on D8521

Test Plan

ran with handler enabled and phabot posted stories

Diff Detail

Repository
rP Phabricator
Branch
feedbot
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/applications/differential/customfield/DifferentialAuditorsField.php:23PHL1Unknown Symbol
Errorsrc/applications/differential/customfield/DifferentialJIRAIssuesField.php:29PHL1Unknown Symbol
Errorsrc/applications/differential/parser/__tests__/DifferentialCommitMessageParserTestCase.php:26PHL1Unknown Symbol
Errorsrc/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php:69PHL1Unknown Symbol
Errorsrc/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php:95PHL1Unknown Symbol
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:41PHL1Unknown Symbol
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:49PHL1Unknown Symbol
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:53PHL1Unknown Symbol
Unit
Tests Skipped

Event Timeline

dctrwatson updated this revision to Diff 20221.Mar 14 2014, 12:46 AM
dctrwatson retitled this revision from to Make PhabricatorBotFeedNotificationHandler work with new PhabricatorApplicationTransactionFeedStory.
dctrwatson updated this object.
dctrwatson edited the test plan for this revision. (Show Details)
dctrwatson added a reviewer: epriestley.
dctrwatson added a parent revision: D8521: Include objectPHID in feed.query text view.
Herald added a reviewer: Blessed Reviewers.Mar 14 2014, 12:46 AM
Herald added subscribers: Korvin, epriestley, aran.
epriestley requested changes to this revision.Mar 14 2014, 12:58 AM
epriestley edited edge metadata.

Minor nits.

src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php
14

For consistency, prefer to spell "Uri" as "URI".

23

Prefer phid_get_type().

157

Prefer phid_get_type() here too.

This revision now requires changes to proceed.Mar 14 2014, 12:58 AM
dctrwatson updated this revision to Diff 20227.Mar 14 2014, 1:04 AM
dctrwatson edited edge metadata.
dctrwatson updated this revision to Diff 20229.Mar 14 2014, 1:15 AM
dctrwatson edited edge metadata.
  • Add 'abandoned'
dctrwatson updated this revision to Diff 20231.Mar 14 2014, 1:18 AM
  • Update usage of typesNeedURI
epriestley accepted this revision.Mar 14 2014, 1:19 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 1:19 AM
epriestley closed this revision.Mar 14 2014, 1:20 AM
epriestley updated this revision to Diff 20232.

Closed by commit rPa5f6e19dfd66 (authored by @dctrwatson, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
infrastructure/
daemon/
bot/
handler/
22 lines

Diff 20229

View Options

src/infrastructure/daemon/bot/handler/PhabricatorBotFeedNotificationHandler.php

Loading...
Phabricator · Built by Phacility