Page MenuHomePhabricator
Differential D8521

Include objectPHID in feed.query text view
ClosedPublic
Actions

Authored by dctrwatson on Mar 14 2014, 12:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 12:36 PM
Unknown Object (File)
Wed, Jan 29, 12:30 PM
Unknown Object (File)
Fri, Jan 24, 10:05 PM
Unknown Object (File)
Thu, Jan 23, 9:53 PM
Unknown Object (File)
Thu, Jan 23, 9:53 PM
Unknown Object (File)
Thu, Jan 23, 9:53 PM
Unknown Object (File)
Wed, Jan 22, 3:16 PM
Unknown Object (File)
Wed, Jan 22, 12:33 PM
View All Files
Subscribers
aran
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP8789f978670d: Include objectPHID in feed.query text view
Summary

This way the type of story can be inferred.

Test Plan

requested feed.query with view=>'text'

Diff Detail

Repository
rP Phabricator
Branch
objphid
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/applications/differential/customfield/DifferentialAuditorsField.php:23PHL1Unknown Symbol
Errorsrc/applications/differential/customfield/DifferentialJIRAIssuesField.php:29PHL1Unknown Symbol
Errorsrc/applications/differential/parser/__tests__/DifferentialCommitMessageParserTestCase.php:26PHL1Unknown Symbol
Errorsrc/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php:69PHL1Unknown Symbol
Errorsrc/infrastructure/__tests__/PhabricatorInfrastructureTestCase.php:95PHL1Unknown Symbol
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:41PHL1Unknown Symbol
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:49PHL1Unknown Symbol
Errorsrc/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php:53PHL1Unknown Symbol
Unit
No Test Coverage

Event Timeline

dctrwatson updated this revision to Diff 20218.Mar 14 2014, 12:28 AM
dctrwatson retitled this revision from to Include objectPHID in feed.query text view.
dctrwatson updated this object.
dctrwatson edited the test plan for this revision. (Show Details)
dctrwatson added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers.Mar 14 2014, 12:28 AM
Herald added subscribers: Korvin, epriestley, aran.
epriestley edited edge metadata.Mar 14 2014, 12:46 AM

do you see how much time I spent writing that lint error

like I poured years of my life into it

epriestley accepted this revision.Mar 14 2014, 12:46 AM
epriestley edited edge metadata.

anyway this probably seems fine

This revision is now accepted and ready to land.Mar 14 2014, 12:46 AM
epriestley closed this revision.Mar 14 2014, 12:56 AM
epriestley updated this revision to Diff 20224.

Closed by commit rP8789f978670d (authored by @dctrwatson, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
feed/
conduit/
1 line

Diff 20218

View Options

src/applications/feed/conduit/ConduitAPI_feed_query_Method.php

Loading...
Phabricator · Built by Phacility