Add missing needReviewerAuthority() for differential.createcomment
ClosedPublic
Actions

Authored by epriestley on Mar 12 2014, 7:40 PM.

Tags

None

Referenced Files

	F13159616: D8505.diff
	Mon, May 6, 2:18 AM

	Unknown Object (File)
	Sat, May 4, 4:45 AM

	Unknown Object (File)
	Thu, May 2, 2:18 PM

	Unknown Object (File)
	Wed, May 1, 8:05 PM

	Unknown Object (File)
	Tue, Apr 30, 4:24 PM

	Unknown Object (File)
	Sun, Apr 28, 9:28 AM

	Unknown Object (File)
	Fri, Apr 26, 10:48 AM

	Unknown Object (File)
	Sat, Apr 20, 8:09 PM

Subscribers

Details

Reviewers

btrahan
dctrwatson

Commits

Restricted Diffusion Commit
rP4173367f8765: Add missing needReviewerAuthority() for differential.createcomment

Summary

For some actions (like accept) we need to load reviewer authority so we can figure out if the actor can act on behalf of project reviewers, etc.

Test Plan

Will make @dctrwatson do it.

Diff Detail

Repository

rP Phabricator

Branch

authority1

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

epriestley updated this revision to Diff 20180.Mar 12 2014, 7:40 PM

epriestley retitled this revision from to Add missing needReviewerAuthority() for differential.createcomment.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, dctrwatson.

epriestley added a subscriber: dctrwatson.

Herald added subscribers: epriestley, aran.Mar 12 2014, 7:40 PM

Also handle the oldschool 'none' action.
Also remove some dead code.

happycat

awesometown

btrahan accepted this revision.Mar 12 2014, 9:48 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 12 2014, 9:48 PM

Closed by commit rP4173367f8765 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

ConduitAPI_differential_createcomment_Method.php

1 line

Diff 20180

View Options

src/applications/differential/conduit/ConduitAPI_differential_createcomment_Method.php

Add missing needReviewerAuthority() for differential.createcommentClosedPublicActions