Add type=submit to AphrontDialogView
ClosedPublic
Actions

Authored by chad on Mar 12 2014, 6:27 PM.

Tags

None

Referenced Files

	F20887062: D8503.id20172.diff
	Fri, Jun 26, 2:15 PM

	F20886932: D8503.id20171.diff
	Fri, Jun 26, 2:14 PM

	F20886494: D8503.diff
	Fri, Jun 26, 2:08 PM

	Unknown Object (File)
	Apr 16 2026, 9:56 PM

	Unknown Object (File)
	Apr 7 2026, 11:56 PM

	Unknown Object (File)
	Apr 4 2026, 9:43 PM

	Unknown Object (File)
	Mar 30 2026, 9:09 PM

	Unknown Object (File)
	Mar 29 2026, 2:56 AM

Subscribers

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP27485bc64415: Add type=submit to AphrontDialogView

Summary

This is required for browsers <= IE7

Test Plan

Inspected HTML for type.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

chad updated this revision to Diff 20171.Mar 12 2014, 6:27 PM

chad retitled this revision from to Add type=submit to AphrontDialogView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley, aran.Mar 12 2014, 6:27 PM

epriestley accepted this revision.Mar 12 2014, 6:28 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 12 2014, 6:28 PM

Closed by commit rP27485bc64415 (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

view/

AphrontDialogView.php

1 line

Diff 20171

View Options

src/view/AphrontDialogView.php

Add type=submit to AphrontDialogViewClosedPublicActions