pretty straight-forward stuff here. Note that in other events we use "fields" or "specification" rather than "revision"; I think "revision" is best particularly in this context where it is in fact the revision being landed.
Fixes T4565.
Differential D8484
Arcanist - add revision data to TYPE_LAND_WILLPUSHREVISION event btrahan on Mar 10 2014, 8:50 PM. Authored by Tags None Referenced Files
Subscribers
Details pretty straight-forward stuff here. Note that in other events we use "fields" or "specification" rather than "revision"; I think "revision" is best particularly in this context where it is in fact the revision being landed. Fixes T4565. php -l
Diff Detail
Event TimelineComment Actions Hmm.. how about we expose getRevision() as a public method instead? Then the callee can access it by grabbing the 'workflow' from the event (which will be this object) and calling getRevision() on it. I think that's a little cleaner / more general / more future-proof. One thing which occurs to me is that you may be landing multiple revisions, especially in the future. So maybe a better implementation would be: public function getRevisions() { return array($this->revision); } ...so we don't back ourselves into a corner if we get better about letting arc land cascade through an entire branch or land multiple known revisions. Comment Actions Not passing the revision and instead adding "getRevisionDict" -- I felt like "Dict" was good to add to the member method as I would assume a revision object otherwise. |