Page MenuHomePhabricator

Exclude disabled (disapproved) users from count on People application on homepage
ClosedPublic

Authored by epriestley on Mar 10 2014, 10:20 PM.
Tags
None
Referenced Files
F14024418: D8486.diff
Thu, Nov 7, 9:19 AM
F13978898: D8486.id20101.diff
Sat, Oct 19, 1:33 AM
F13978785: D8486.id.diff
Sat, Oct 19, 12:57 AM
F13978691: D8486.id20101.diff
Sat, Oct 19, 12:30 AM
F13978659: D8486.diff
Sat, Oct 19, 12:22 AM
F13978422: D8486.diff
Fri, Oct 18, 11:05 PM
F13978397: D8486.diff
Fri, Oct 18, 10:59 PM
F13962714: D8486.id20102.diff
Tue, Oct 15, 11:51 AM
Subscribers

Details

Summary

The People application shows users awaiting approval, but incorrectly counts disabled users (i.e., users who were not approved).

Instead, count only non-disabled, non-approved users.

Test Plan

My homepage count dropped from 4 to 1, corresponding to the actual number of accounts.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 10 2014, 10:26 PM
epriestley updated this revision to Diff 20102.

Closed by commit rP0a779b60a285 (authored by @epriestley).