Hovercard - add project images
ClosedPublic
Actions

Authored by btrahan on Mar 10 2014, 8:38 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T3991: Add project icons to hovercards

Commits

Restricted Diffusion Commit
rP8e4131523812: Hovercard - add project images

Summary

adds project images. Also fiddles with HTML + CSS just a bit so we have a "picture" column and a "details" column if a picture exists.

This keeps the details all in a nice column even if there are many details that end up being taller than the picture UI.

Fixes T3991.

Test Plan

looked at a task (no pic), project (pic w/ no details), and user (pic w/ many details) hovercard and all looked good on Chrome and Safari

Diff Detail

Repository

rP Phabricator

Branch

T3991

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

fix spacing

btrahan added a reviewer: chad.Mar 10 2014, 8:40 PM

epriestley accepted this revision.Mar 11 2014, 12:11 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/view/widget/hovercard/PhabricatorHovercardView.php
119	We should modernize this to: array($x, $y) ...instead of: $x->appendHTML($y)

This revision is now accepted and ready to land.Mar 11 2014, 12:11 AM

Closed by commit rP8e4131523812 (authored by @btrahan, committed by @epriestley).

...so did you mean to take this over and land this? I don't mind (obvipants) just asking because its a new workflow for us and could be indicative of some bugz.

Oops! I patched it into my sandbox and then stuck something on top of it. I made a similar mistake recently too, I'll see if we can add a warning about this.