Page MenuHomePhabricator
Files F15396408

D8483.id20107.diff
No OneTemporary
Actions

D8483.id20107.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -121,7 +121,7 @@
'rsrc/css/layout/phabricator-action-list-view.css' => '81383e25',
'rsrc/css/layout/phabricator-crumbs-view.css' => '2d9db584',
'rsrc/css/layout/phabricator-filetree-view.css' => 'a8c86ace',
- 'rsrc/css/layout/phabricator-hovercard-view.css' => '67c12b16',
+ 'rsrc/css/layout/phabricator-hovercard-view.css' => '46a13cf0',
'rsrc/css/layout/phabricator-side-menu-view.css' => '503699d0',
'rsrc/css/layout/phabricator-source-code-view.css' => '62a99814',
'rsrc/css/phui/calendar/phui-calendar-day.css' => 'de035c8a',
@@ -696,7 +696,7 @@
'phabricator-filetree-view-css' => 'a8c86ace',
'phabricator-flag-css' => '5337623f',
'phabricator-hovercard' => '4f344388',
- 'phabricator-hovercard-view-css' => '67c12b16',
+ 'phabricator-hovercard-view-css' => '46a13cf0',
'phabricator-jump-nav' => 'f0c5e726',
'phabricator-keyboard-shortcut' => '1ae869f2',
'phabricator-keyboard-shortcut-manager' => 'ad7a69ca',
diff --git a/src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php b/src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php
--- a/src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php
+++ b/src/applications/project/phid/PhabricatorProjectPHIDTypeProject.php
@@ -25,7 +25,8 @@
array $phids) {
return id(new PhabricatorProjectQuery())
- ->withPHIDs($phids);
+ ->withPHIDs($phids)
+ ->needImages(true);
}
public function loadHandles(
@@ -42,6 +43,7 @@
$handle->setName($name);
$handle->setObjectName('#'.rtrim($project->getPhrictionSlug(), '/'));
$handle->setURI("/project/view/{$id}/");
+ $handle->setImageURI($project->getProfileImageURI());
if ($project->isArchived()) {
$handle->setStatus(PhabricatorObjectHandleStatus::STATUS_CLOSED);
diff --git a/src/view/widget/hovercard/PhabricatorHovercardView.php b/src/view/widget/hovercard/PhabricatorHovercardView.php
--- a/src/view/widget/hovercard/PhabricatorHovercardView.php
+++ b/src/view/widget/hovercard/PhabricatorHovercardView.php
@@ -18,7 +18,6 @@
private $actions = array();
private $color = 'blue';
-
public function setObjectHandle(PhabricatorObjectHandle $handle) {
$this->handle = $handle;
return $this;
@@ -109,11 +108,21 @@
$body = phutil_tag(
'div',
array(
- 'class' => 'profile-header-picture-frame',
- 'style' => 'background-image: url('.$handle->getImageURI().');',
- ),
- '')
- ->appendHTML($body);
+ 'class' => 'phabricator-hovercard-body-image'),
+ phutil_tag(
+ 'div',
+ array(
+ 'class' => 'profile-header-picture-frame',
+ 'style' => 'background-image: url('.$handle->getImageURI().');',
+ ),
+ ''))
+ ->appendHTML(
+ phutil_tag(
+ 'div',
+ array(
+ 'class' => 'phabricator-hovercard-body-details',
+ ),
+ $body));
}
$buttons = array();
diff --git a/webroot/rsrc/css/layout/phabricator-hovercard-view.css b/webroot/rsrc/css/layout/phabricator-hovercard-view.css
--- a/webroot/rsrc/css/layout/phabricator-hovercard-view.css
+++ b/webroot/rsrc/css/layout/phabricator-hovercard-view.css
@@ -7,6 +7,7 @@
}
.phabricator-hovercard-wrapper {
+ float: left;
border-radius: 5px;
width: 400px;
padding: 6px;
@@ -14,10 +15,13 @@
}
.device-phone .phabricator-hovercard-wrapper {
+ float: left;
width: 300px;
}
.phabricator-hovercard-container {
+ float: left;
+ width: 100%;
border: 1px solid {$greytext};
}
@@ -27,22 +31,39 @@
}
.phabricator-hovercard-body {
- padding: 8px;
+ float: left;
+ width: 100%;
+ padding: 8px 0px 8px 0px;
background-color: white;
color: {$darkgreytext};
}
+.phabricator-hovercard-body-header,
+.phabricator-hovercard-body-item {
+ margin: 0px 0px 0px 8px;
+}
+
.phabricator-hovercard-body-header {
font-size: 13px;
padding-bottom: 2px;
color: {$darkgreytext};
}
+.phabricator-hovercard-body .phabricator-hovercard-body-image {
+ clear: left;
+ float: left;
+ width: 58px;
+}
+
+.phabricator-hovercard-body .phabricator-hovercard-body-details {
+ clear: right;
+ float: left;
+ width: 342px;
+}
+
.phabricator-hovercard-body .profile-header-picture-frame {
float: left;
- margin: 0;
- margin-right: 10px;
- margin-bottom: 5px;
+ margin: 0px 8px 0px 8px;
width: 50px;
height: 50px;
background-position: center;
@@ -50,6 +71,8 @@
}
.phabricator-hovercard-tail {
+ width: 396px;
+ float: left;
padding: 3px 2px;
background-color: #eeeeee;
border-bottom-left-radius: 2px;

File Metadata

Mime Type
text/plain
Expires
Mon, Mar 17, 2:00 PM (3 d, 11 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7601538
Default Alt Text
D8483.id20107.diff (4 KB)

Event Timeline

Phabricator · Built by Phacility