See discussion in D8460. Primarily, this prints out the failing value when a true/false assertion fails, so if it was something useful (like a function result) it's visible.
Details
Details
Added assertTrue("quack"):
FAIL ArcanistDiffParserTestCase::testParser Assertion failed, expected 'true' (at ArcanistDiffParserTestCase.php:16). ACTUAL VALUE quack
Added assertFalse("quack"):
FAIL ArcanistDiffParserTestCase::testParser Assertion failed, expected 'false' (at ArcanistDiffParserTestCase.php:16). ACTUAL VALUE quack
Added assertEqual("quack", "moo"):
FAIL ArcanistDiffParserTestCase::testParser Assertion failed, expected values to be equal (at ArcanistDiffParserTestCase.php:16). Expected: quack Actual: moo
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
90% of the time it's probably not useful (especially if you're judicious about assertEqual() even when the expected parameter is false), but I think it's never really worse.