Page MenuHomePhabricator
Differential D8443

Remove DifferentialCommentEditor and DifferentialCommentMail
ClosedPublic
Actions

Authored by epriestley on Mar 7 2014, 8:18 PM.
Tags
None
Referenced Files
F13259719: D8443.diff
Sun, May 26, 11:00 PM
F13242449: D8443.diff
Thu, May 23, 2:46 AM
F13227307: D8443.id.diff
Mon, May 20, 2:29 AM
F13226192: D8443.id20038.diff
Sun, May 19, 7:29 PM
F13220597: D8443.diff
Sun, May 19, 1:48 AM
F13216286: D8443.id20045.diff
Fri, May 17, 11:46 PM
F13202605: D8443.diff
Tue, May 14, 10:54 PM
F13185463: D8443.diff
Sat, May 11, 2:56 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rPf25cce1e695b: Remove DifferentialCommentEditor and DifferentialCommentMail
Summary

Ref T2222. These no longer have any callsites. Also got rid of a little bit of other code which also no longer has callsites.

Test Plan

grep

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 8 2014, 12:26 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2014, 12:26 AM
epriestley closed this revision.Mar 8 2014, 1:44 AM

Closed by commit rPf25cce1e695b (authored by @epriestley).

Revision Contents
Changeset List

Diff 20045

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/editor/DifferentialCommentEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialRevisionEditor.php

Loading...
View Options

src/applications/differential/exception/DifferentialActionHasNoEffectException.php

Loading...
View Options

src/applications/differential/mail/DifferentialCommentMail.php

Loading...
Phabricator · Built by Phacility