Page MenuHomePhabricator

Fail Arcanist tests when they make zero assertions
ClosedPublic

Authored by epriestley on Mar 7 2014, 2:23 PM.
Tags
None
Referenced Files
F14034605: D8437.id20021.diff
Sun, Nov 10, 1:17 AM
F14033806: D8437.diff
Sat, Nov 9, 8:14 PM
F14026778: D8437.diff
Fri, Nov 8, 2:09 AM
F13993500: D8437.id.diff
Tue, Oct 22, 11:16 PM
F13984807: D8437.id20021.diff
Sun, Oct 20, 4:05 PM
F13980000: D8437.diff
Sat, Oct 19, 7:50 AM
Unknown Object (File)
Oct 7 2024, 8:21 AM
Unknown Object (File)
Sep 24 2024, 7:43 PM
Subscribers

Details

Summary

Fixes T4570. When a test case doesn't make any assertions, fail it:

  • A tiny fraction of tests pass by not throwing. These tests can easily make a trivial assertion. It took about 5 minutes to fix them all (D8435, D8436).
  • In other cases, no assertions means a test construction problem, as with T4570. In these cases, failing loudly catches a severe error.
  • Fixes the no-assertion test cases in arcanist/
  • Makes the PHP 5.4 test pass for the moment, see discussion in T4334.
Test Plan

Ran arc unit --everything.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 7 2014, 5:51 PM