Page MenuHomePhabricator

Fail Arcanist tests when they make zero assertions
ClosedPublic

Authored by epriestley on Mar 7 2014, 2:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 6:03 PM
Unknown Object (File)
Wed, Nov 20, 9:39 PM
Unknown Object (File)
Fri, Nov 15, 8:53 PM
Unknown Object (File)
Tue, Nov 12, 9:13 AM
Unknown Object (File)
Sun, Nov 10, 1:17 AM
Unknown Object (File)
Sat, Nov 9, 8:14 PM
Unknown Object (File)
Fri, Nov 8, 2:09 AM
Unknown Object (File)
Oct 22 2024, 11:16 PM
Subscribers

Details

Summary

Fixes T4570. When a test case doesn't make any assertions, fail it:

  • A tiny fraction of tests pass by not throwing. These tests can easily make a trivial assertion. It took about 5 minutes to fix them all (D8435, D8436).
  • In other cases, no assertions means a test construction problem, as with T4570. In these cases, failing loudly catches a severe error.
  • Fixes the no-assertion test cases in arcanist/
  • Makes the PHP 5.4 test pass for the moment, see discussion in T4334.
Test Plan

Ran arc unit --everything.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 7 2014, 5:51 PM