Page MenuHomePhabricator
Differential D8403

Add an explcit "Changes Planned" state for Differential
ClosedPublic
Actions

Authored by epriestley on Mar 5 2014, 2:18 AM.
Tags
None
Referenced Files
F15453442: D8403.id19970.diff
Sat, Mar 29, 11:49 AM
F15443622: D8403.diff
Thu, Mar 27, 5:18 AM
F15433884: D8403.diff
Tue, Mar 25, 1:02 AM
F15414792: D8403.id.diff
Thu, Mar 20, 2:33 AM
F15387836: D8403.id19970.diff
Sat, Mar 15, 2:59 AM
Unknown Object (File)
Feb 24 2025, 9:10 AM
Unknown Object (File)
Feb 23 2025, 5:11 AM
Unknown Object (File)
Feb 23 2025, 5:11 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
T4481: Differential Update Feedback / Rough Edges / Status
Commits
Restricted Diffusion Commit
rP4ef87eeac832: Add an explcit "Changes Planned" state for Differential
Summary

Ref T2222. Ref T4481. This fixes the issue where "Plan Changes" could immediately trigger a state change (e.g., back to accepted) because of state-based transitions out of the NEEDS_REVISION state.

Test Plan

Planned changes an "accepted" revision, it didn't immediately return to being accepted.

Diff Detail

Repository
rP Phabricator
Branch
statetrans3
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

btrahan accepted this revision.Mar 5 2014, 6:36 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 5 2014, 6:36 PM
epriestley closed this revision.Mar 5 2014, 6:48 PM

Closed by commit rP4ef87eeac832 (authored by @epriestley).

Revision Contents
Changeset List

Diff 19957

View Options

src/applications/differential/constants/DifferentialRevisionStatus.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/differential/editor/DifferentialRevisionEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionListView.php

Loading...
Phabricator · Built by Phacility