Page MenuHomePhabricator
Differential D8378

Clean up some Differential behaviors
ClosedPublic
Actions

Authored by epriestley on Mar 1 2014, 1:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 10:41 AM
Unknown Object (File)
Fri, Dec 20, 10:24 AM
Unknown Object (File)
Fri, Dec 20, 4:25 AM
Unknown Object (File)
Wed, Dec 4, 3:52 PM
Unknown Object (File)
Wed, Dec 4, 12:42 PM
Unknown Object (File)
Tue, Dec 3, 8:38 PM
Unknown Object (File)
Thu, Nov 28, 2:30 AM
Unknown Object (File)
Wed, Nov 27, 6:51 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Maniphest Tasks
T2222: Implement ApplicationTransactions in Differential
Commits
Restricted Diffusion Commit
rP83206242c9dd: Clean up some Differential behaviors
Summary

Ref T2222.

  • Restore mail tags for ApplicationTransactions mail.
  • Restore subject line verbs.
  • Denormalize line count and repository PHID.
  • Fix an issue with the mailgun adapter where headers weren't attached properly.
Test Plan

Sent some mail, verified it had correct subjects and tags.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan accepted this revision.Mar 3 2014, 4:31 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2014, 4:31 PM
epriestley closed this revision.Mar 3 2014, 4:36 PM

Closed by commit rP83206242c9dd (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
4 lines
storage/
63 lines
metamta/
adapter/
5 lines

Diff 19926

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php

Loading...
Phabricator · Built by Phacility