Page MenuHomePhabricator

Truncate Conduit 'clientDescription' so we don't overflow the column
ClosedPublic

Authored by epriestley on Feb 24 2014, 11:31 PM.
Tags
None
Referenced Files
F15382843: D8327.id19826.diff
Fri, Mar 14, 2:40 PM
F15382839: D8327.id19802.diff
Fri, Mar 14, 2:40 PM
F15382315: D8327.id19826.diff
Fri, Mar 14, 11:50 AM
F15382312: D8327.id19802.diff
Fri, Mar 14, 11:50 AM
F15282727: D8327.diff
Tue, Mar 4, 1:50 AM
Unknown Object (File)
Mon, Feb 24, 7:20 AM
Unknown Object (File)
Mon, Feb 17, 1:30 PM
Unknown Object (File)
Mon, Feb 17, 1:30 PM
Subscribers

Details

Summary

We store the arc commandline in this 255-character column, but it can be more than 255-characters long. If it's huge, truncate it.

Test Plan

Executed:

arc list --conduit-uri=http://local.aphront.com:8080/ --conduit-version 6.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

Works fine after this patch.

Diff Detail

Repository
rP Phabricator
Branch
truncdesc
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/conduit/method/ConduitAPI_conduit_connect_Method.php:64XHP16TODO Comment
Unit
No Test Coverage