Page MenuHomePhabricator

Truncate Conduit 'clientDescription' so we don't overflow the column
ClosedPublic

Authored by epriestley on Feb 24 2014, 11:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 10, 10:42 AM
Unknown Object (File)
Wed, Sep 4, 8:15 AM
Unknown Object (File)
Mon, Aug 26, 7:10 AM
Unknown Object (File)
Sun, Aug 25, 4:44 PM
Unknown Object (File)
Thu, Aug 22, 11:58 AM
Unknown Object (File)
Aug 11 2024, 7:42 AM
Unknown Object (File)
Aug 11 2024, 1:34 AM
Unknown Object (File)
Aug 7 2024, 8:38 AM
Subscribers

Details

Summary

We store the arc commandline in this 255-character column, but it can be more than 255-characters long. If it's huge, truncate it.

Test Plan

Executed:

arc list --conduit-uri=http://local.aphront.com:8080/ --conduit-version 6.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

Works fine after this patch.

Diff Detail

Repository
rP Phabricator
Branch
truncdesc
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/conduit/method/ConduitAPI_conduit_connect_Method.php:64XHP16TODO Comment
Unit
No Test Coverage