Page MenuHomePhabricator

Implement Differential subscribers as a CustomField
ClosedPublic

Authored by epriestley on Feb 21 2014, 1:44 AM.
Tags
None
Referenced Files
F13358221: D8289.id19729.diff
Tue, Jun 25, 6:40 AM
F13346706: D8289.diff
Fri, Jun 21, 6:45 PM
F13346705: D8289.diff
Fri, Jun 21, 6:45 PM
F13337276: D8289.diff
Wed, Jun 19, 9:22 AM
F13324515: D8289.diff
Sat, Jun 15, 12:40 AM
F13312103: D8289.diff
Tue, Jun 11, 6:07 AM
F13297757: D8289.diff
Fri, Jun 7, 5:55 AM
F13272591: D8289.id.diff
Thu, May 30, 4:05 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPaa7ba4c6e6d6: Implement Differential subscribers as a CustomField
Summary

Ref T3886. Now that a custom field can emit a core transaction, just emit a subscribers transaction.

Test Plan

{F116014}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/customfield/DifferentialCoreCustomField.php
17–22

Subclasses of CoreField only need to implement this if they're using a TYPE_CUSTOMFIELD transaction. Otherwise we'll do the write as part of the SUBSCRIBERS or EDGE or VIEW_POLICY or whatever else transaction.

src/applications/differential/customfield/DifferentialRepositoryField.php
32

(Small derp on my part.)