Page MenuHomePhabricator

Implement Differential subscribers as a CustomField
ClosedPublic

Authored by epriestley on Feb 21 2014, 1:44 AM.
Tags
None
Referenced Files
F13272591: D8289.id.diff
Thu, May 30, 4:05 PM
F13247486: D8289.diff
Thu, May 23, 7:40 PM
F13230800: D8289.diff
Mon, May 20, 11:19 PM
F13210525: D8289.diff
Fri, May 17, 4:56 AM
F13196143: D8289.diff
Sun, May 12, 11:00 PM
Unknown Object (File)
May 3 2024, 2:49 AM
Unknown Object (File)
Apr 29 2024, 2:16 PM
Unknown Object (File)
Apr 24 2024, 10:05 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPaa7ba4c6e6d6: Implement Differential subscribers as a CustomField
Summary

Ref T3886. Now that a custom field can emit a core transaction, just emit a subscribers transaction.

Test Plan

{F116014}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/customfield/DifferentialCoreCustomField.php
17–22

Subclasses of CoreField only need to implement this if they're using a TYPE_CUSTOMFIELD transaction. Otherwise we'll do the write as part of the SUBSCRIBERS or EDGE or VIEW_POLICY or whatever else transaction.

src/applications/differential/customfield/DifferentialRepositoryField.php
32

(Small derp on my part.)