Page MenuHomePhabricator

Implement Differential subscribers as a CustomField
ClosedPublic

Authored by epriestley on Feb 21 2014, 1:44 AM.
Tags
None
Referenced Files
F15475528: D8289.id19716.diff
Sun, Apr 6, 8:09 PM
F15456042: D8289.diff
Sun, Mar 30, 6:37 AM
F15430585: D8289.diff
Mon, Mar 24, 8:18 AM
Unknown Object (File)
Mar 1 2025, 2:38 PM
Unknown Object (File)
Feb 1 2025, 6:29 PM
Unknown Object (File)
Feb 1 2025, 1:24 PM
Unknown Object (File)
Jan 27 2025, 10:09 PM
Unknown Object (File)
Jan 27 2025, 2:25 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPaa7ba4c6e6d6: Implement Differential subscribers as a CustomField
Summary

Ref T3886. Now that a custom field can emit a core transaction, just emit a subscribers transaction.

Test Plan

{F116014}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

src/applications/differential/customfield/DifferentialCoreCustomField.php
17–22

Subclasses of CoreField only need to implement this if they're using a TYPE_CUSTOMFIELD transaction. Otherwise we'll do the write as part of the SUBSCRIBERS or EDGE or VIEW_POLICY or whatever else transaction.

src/applications/differential/customfield/DifferentialRepositoryField.php
32

(Small derp on my part.)