Paths

Table of Contentst

Differential D8263

Bring "fixes x as y" parser forward and use new parsers instead of old ones
ClosedPublic
Actions

Authored by epriestley on Feb 17 2014, 8:10 PM.

Tags

None

Referenced Files

	F16883387: D8263.id.diff
	Wed, Jun 18, 12:48 PM

	F16743616: D8263.id19662.diff
	Tue, Jun 17, 9:19 PM

	F16725748: D8263.id19653.diff
	Tue, Jun 17, 7:02 PM

	F16715511: D8263.diff
	Tue, Jun 17, 6:01 PM

	Unknown Object (File)
	Tue, Jun 17, 12:52 PM

	Unknown Object (File)
	Mon, May 19, 7:40 PM

	Unknown Object (File)
	May 8 2025, 9:19 AM

	Unknown Object (File)
	May 6 2025, 9:10 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T1812: Allow for arbitrary values for task status
Restricted Maniphest Task
Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP8a725ece0f8b: Bring "fixes x as y" parser forward and use new parsers instead of old ones

Summary

Fixes T3872. Ref T1812. Ref T3886. Modernize the "closes x as y" string parser, and use all the new parsers instead of the old ones.

Test Plan

Made a commit full of a pile of these trigger strings, then used scripts/repository/reparse.php --message to reparse it. Verified that parses came back as expected using a bunch of var_dump().

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley added inline comments.Feb 17 2014, 8:11 PM

src/applications/differential/field/specification/DifferentialFreeformFieldSpecification.php
12–45	This duplicated stuff is going away soon.
src/applications/maniphest/field/parser/__tests__/ManiphestCustomFieldStatusParserTestCase.php
4	Oops, this didn't get updated properly. I'll update.

Include appropriate unit tests.

btrahan accepted this revision.Feb 17 2014, 10:22 PM

Closed by commit rP8a725ece0f8b (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

applications/

differential/

field/

specification/

DifferentialFreeformFieldSpecification.php

94 lines

maniphest/

field/

parser/

ManiphestCustomFieldStatusParser.php

59 lines

__tests__/

ManiphestCustomFieldStatusParserTestCase.php

63 lines

infrastructure/

customfield/

parser/

PhabricatorCustomFieldMonogramParser.php

2 lines

Diff 19662

src/__phutil_library_map__.php

Loading...

src/applications/differential/field/specification/DifferentialFreeformFieldSpecification.php

Loading...

src/applications/maniphest/field/parser/ManiphestCustomFieldStatusParser.php

Loading...

src/applications/maniphest/field/parser/tests/ManiphestCustomFieldStatusParserTestCase.php

Loading...

src/infrastructure/customfield/parser/PhabricatorCustomFieldMonogramParser.php

Loading...