Page MenuHomePhabricator

Bring "fixes x as y" parser forward and use new parsers instead of old ones
ClosedPublic

Authored by epriestley on Feb 17 2014, 8:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 2:55 PM
Unknown Object (File)
Thu, Nov 14, 4:01 AM
Unknown Object (File)
Wed, Nov 13, 5:35 PM
Unknown Object (File)
Sun, Nov 10, 10:44 AM
Unknown Object (File)
Thu, Nov 7, 3:58 AM
Unknown Object (File)
Sat, Nov 2, 6:55 AM
Unknown Object (File)
Sun, Oct 27, 5:16 PM
Unknown Object (File)
Sat, Oct 26, 4:06 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
T1812: Allow for arbitrary values for task status
Restricted Maniphest Task
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP8a725ece0f8b: Bring "fixes x as y" parser forward and use new parsers instead of old ones
Summary

Fixes T3872. Ref T1812. Ref T3886. Modernize the "closes x as y" string parser, and use all the new parsers instead of the old ones.

Test Plan

Made a commit full of a pile of these trigger strings, then used scripts/repository/reparse.php --message to reparse it. Verified that parses came back as expected using a bunch of var_dump().

Diff Detail

Repository
rP Phabricator
Branch
diff3
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

src/applications/differential/field/specification/DifferentialFreeformFieldSpecification.php
12–45

This duplicated stuff is going away soon.

src/applications/maniphest/field/parser/__tests__/ManiphestCustomFieldStatusParserTestCase.php
4

Oops, this didn't get updated properly. I'll update.

epriestley updated this revision to Unknown Object (????).Feb 17 2014, 8:17 PM
  • Include appropriate unit tests.