Ref T2222. Restore this funky is-visible / inline-is-elsewhere logic.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T2222: Implement ApplicationTransactions in Differential
- Commits
- Restricted Diffusion Commit
rP7374a0a4d4f5: Fix inline comment links for non-visible comments
Updated a revision, saw all the inlines render properly when looking at various diffs and versus-diffs. Clicked inline links.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dui3
- Lint
Lint Passed - Unit
Tests Passed
Event Timeline
| src/applications/differential/editor/DifferentialRevisionEditor.php | ||
|---|---|---|
| 705 | Fixes a similar content source issue to the CommentEditor one -- this one was on the web update pathway. | |
| src/applications/differential/view/DifferentialTransactionView.php | ||
| 133–134 | I realized that this was probably wrong too, and would sort 11 before 9. Since we should rarely have files which are more than 2^16 lines long, and also rarely have comments that are more than 2^16 lines long, just do some bit fiddling. | |