Differential D8204

Before launching $EDITOR from arc, print that we're doing it
AbandonedPublic
Actions

Authored by rugabarbo on Feb 12 2014, 2:01 PM.

Tags

None

Referenced Files

	F15408443: D8204.diff
	Tue, Mar 18, 11:05 PM

	F15354332: D8204.id.diff
	Tue, Mar 11, 3:26 AM

	Unknown Object (File)
	Feb 17 2025, 1:22 PM

	Unknown Object (File)
	Feb 15 2025, 1:22 AM

	Unknown Object (File)
	Feb 15 2025, 1:22 AM

	Unknown Object (File)
	Feb 9 2025, 11:27 AM

	Unknown Object (File)
	Feb 9 2025, 11:27 AM

	Unknown Object (File)
	Feb 9 2025, 11:27 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Summary

Ref T3271.

Test Plan

Launch any arc command that require editor launching;
Make sure that the message about launching editor is present in console output.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

rugabarbo added inline comments.Feb 14 2014, 9:34 AM

src/console/PhutilInteractiveEditor.php
100	It's my first commit for libphutil and so I have some "beginner"-question :-) Is it OK, that I used console output directly into invokeEditor( ) low-level method?

rugabarbo abandoned this revision.Apr 16 2014, 4:54 PM

Revision Contents
Changeset List

Path

Size

src/

console/

PhutilInteractiveEditor.php

3 lines

Diff 18559

src/console/PhutilInteractiveEditor.php

Loading...