Page MenuHomePhabricator

Before launching $EDITOR from arc, print that we're doing it
AbandonedPublic

Authored by rugabarbo on Feb 12 2014, 2:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 18, 3:08 PM
Unknown Object (File)
Dec 18 2024, 3:43 AM
Unknown Object (File)
Dec 14 2024, 1:31 PM
Unknown Object (File)
Dec 12 2024, 5:11 PM
Unknown Object (File)
Dec 8 2024, 10:22 PM
Unknown Object (File)
Dec 8 2024, 5:51 PM
Unknown Object (File)
Dec 6 2024, 10:33 AM
Unknown Object (File)
Dec 6 2024, 8:25 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Ref T3271.

Test Plan
  1. Launch any arc command that require editor launching;
  2. Make sure that the message about launching editor is present in console output.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

src/console/PhutilInteractiveEditor.php
100

It's my first commit for libphutil and so I have some "beginner"-question :-)
Is it OK, that I used console output directly into invokeEditor( ) low-level method?