Page MenuHomePhabricator

Before launching $EDITOR from arc, print that we're doing it
AbandonedPublic

Authored by rugabarbo on Feb 12 2014, 2:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 9, 1:55 AM
Unknown Object (File)
May 8 2025, 2:48 PM
Unknown Object (File)
May 7 2025, 9:58 AM
Unknown Object (File)
May 6 2025, 8:23 PM
Unknown Object (File)
May 6 2025, 9:04 AM
Unknown Object (File)
May 6 2025, 9:04 AM
Unknown Object (File)
Apr 19 2025, 12:29 PM
Unknown Object (File)
Apr 10 2025, 1:42 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Ref T3271.

Test Plan
  1. Launch any arc command that require editor launching;
  2. Make sure that the message about launching editor is present in console output.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

src/console/PhutilInteractiveEditor.php
100

It's my first commit for libphutil and so I have some "beginner"-question :-)
Is it OK, that I used console output directly into invokeEditor( ) low-level method?