Page MenuHomePhabricator

Fix alternate filtering conditions in object selector dialog
ClosedPublic

Authored by epriestley on Feb 10 2014, 10:51 PM.
Tags
None
Referenced Files
F15410871: D8188.diff
Wed, Mar 19, 8:36 AM
F15410851: D8188.diff
Wed, Mar 19, 8:33 AM
F15410831: D8188.diff
Wed, Mar 19, 8:31 AM
F15410811: D8188.diff
Wed, Mar 19, 8:28 AM
F15410792: D8188.diff
Wed, Mar 19, 8:25 AM
F15410745: D8188.diff
Wed, Mar 19, 8:20 AM
F15410729: D8188.diff
Wed, Mar 19, 8:18 AM
F15410496: D8188.diff
Wed, Mar 19, 7:30 AM
Subscribers

Details

Summary

These didn't get updated either when the main search got rebuilt. Adjust and modernize them. Also this uses "exclude", which I couldn't find any callsites for but just missed, so restore that.

At some point I plan to swap this whole thing to ApplicationSearch and that will let us get rid of a bunch of stuff.

Test Plan

Searched for all filters, got sensible results, verified source object doesn't show up as a result.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped