Page MenuHomePhabricator

Fix accidental forward dependency in old commit summary migration
ClosedPublic

Authored by epriestley on Feb 5 2014, 10:53 PM.
Tags
None
Referenced Files
F14359963: D8152.id18441.diff
Fri, Dec 20, 9:49 AM
F14357103: D8152.diff
Fri, Dec 20, 2:39 AM
Unknown Object (File)
Mon, Dec 9, 1:59 AM
Unknown Object (File)
Sun, Dec 8, 12:13 PM
Unknown Object (File)
Wed, Dec 4, 10:51 PM
Unknown Object (File)
Wed, Nov 27, 4:24 AM
Unknown Object (File)
Tue, Nov 26, 4:57 PM
Unknown Object (File)
Tue, Nov 26, 10:01 AM
Subscribers

Details

Summary

See IRC. This migration inadvertently depends on the columns in the commit table, because it calls save(), and thus broke for installs with data after we added the importStatus column. Since that was ~9 months after this patch, probably not many installs are affected.

Test Plan

Ran patch locally with --apply on data. Had user verify fix.

Diff Detail

Repository
rP Phabricator
Branch
savepatch
Lint
Lint Passed
Unit
No Test Coverage