Page MenuHomePhabricator

Fix accidental forward dependency in old commit summary migration
ClosedPublic

Authored by epriestley on Feb 5 2014, 10:53 PM.
Tags
None
Referenced Files
F13812593: D8152.diff
Wed, Sep 18, 3:51 PM
Unknown Object (File)
Sun, Sep 8, 8:36 PM
Unknown Object (File)
Mon, Sep 2, 2:25 PM
Unknown Object (File)
Thu, Aug 29, 10:29 PM
Unknown Object (File)
Mon, Aug 26, 12:01 AM
Unknown Object (File)
Wed, Aug 21, 1:36 PM
Unknown Object (File)
Aug 19 2024, 3:32 AM
Unknown Object (File)
Aug 17 2024, 5:44 AM
Subscribers

Details

Summary

See IRC. This migration inadvertently depends on the columns in the commit table, because it calls save(), and thus broke for installs with data after we added the importStatus column. Since that was ~9 months after this patch, probably not many installs are affected.

Test Plan

Ran patch locally with --apply on data. Had user verify fix.

Diff Detail

Repository
rP Phabricator
Branch
savepatch
Lint
Lint Passed
Unit
No Test Coverage