Page MenuHomePhabricator

Add "%R" to csprintf(), for printing more readable commands
ClosedPublic

Authored by epriestley on Jan 29 2014, 10:02 PM.
Tags
None
Referenced Files
F19824129: D8099.id18322.diff
Sat, Mar 7, 7:37 PM
F19806650: D8099.id18336.diff
Tue, Mar 3, 1:09 AM
F19798762: D8099.id.diff
Fri, Feb 27, 10:16 PM
F19792680: D8099.diff
Thu, Feb 26, 1:57 PM
F19773163: D8099.id18336.diff
Sat, Feb 21, 1:34 AM
F19757691: D8099.id18336.diff
Tue, Feb 17, 7:53 PM
F19710376: D8099.id.diff
Wed, Feb 11, 4:40 PM
F19709188: D8099.id.diff
Wed, Feb 11, 1:57 PM
Subscribers

Details

Summary

Ref T4175. The clone commands we print have quoted arguments, but usually don't need them. Add "%R", which is like "%s" but only adds quotes if they're required. This produces slightly more readable commands in the few cases we're generating commands for users to copy/paste.

Test Plan

Added unit tests. Looked up shell metacharacters to double check my definition.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped