Page MenuHomePhabricator

Add a "branches" rule for commits
ClosedPublic

Authored by epriestley on Jan 28 2014, 4:40 PM.
Tags
None
Referenced Files
F20918228: D8086.id18298.diff
Sat, Jun 27, 3:03 AM
F20918139: D8086.id18291.diff
Sat, Jun 27, 3:01 AM
F20915992: D8086.id18294.diff
Sat, Jun 27, 1:47 AM
Unknown Object (File)
Thu, Jun 25, 6:45 AM
Unknown Object (File)
Thu, May 28, 1:18 PM
Unknown Object (File)
Apr 18 2026, 6:44 PM
Unknown Object (File)
Apr 14 2026, 7:13 PM
Unknown Object (File)
Mar 27 2026, 5:17 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPe9be9ecfbcc9: Add a "branches" rule for commits
Summary

Fixes T1353. Also some minor unrelated cleanup:

  • openTransaction() / saveTransaction() exist now, fix TODOs.
  • Fix some instructions.
  • Make diffusion.branchquery return empty for SVN rather than fataling.
Test Plan
  • Added a branches rule.
  • Ran a dry run against commits in different VCSes.

{F105574}

Diff Detail

Repository
rP Phabricator
Branch
hbranch
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 28 2014, 5:26 PM
  • Include the change which just makes SVN return empty (instead of error).