Page MenuHomePhabricator

Add a "branches" rule for commits
ClosedPublic

Authored by epriestley on Jan 28 2014, 4:40 PM.
Tags
None
Referenced Files
F14379674: D8086.diff
Sat, Dec 21, 3:07 AM
Unknown Object (File)
Wed, Dec 11, 1:00 PM
Unknown Object (File)
Fri, Dec 6, 2:27 PM
Unknown Object (File)
Wed, Dec 4, 2:52 PM
Unknown Object (File)
Wed, Dec 4, 2:52 PM
Unknown Object (File)
Wed, Dec 4, 2:52 PM
Unknown Object (File)
Wed, Dec 4, 2:52 PM
Unknown Object (File)
Wed, Dec 4, 2:34 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPe9be9ecfbcc9: Add a "branches" rule for commits
Summary

Fixes T1353. Also some minor unrelated cleanup:

  • openTransaction() / saveTransaction() exist now, fix TODOs.
  • Fix some instructions.
  • Make diffusion.branchquery return empty for SVN rather than fataling.
Test Plan
  • Added a branches rule.
  • Ran a dry run against commits in different VCSes.

{F105574}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 28 2014, 5:26 PM
  • Include the change which just makes SVN return empty (instead of error).