Improve some messaging in `arc which` for autodetection of repositories
ClosedPublic
Actions

Authored by epriestley on Jan 28 2014, 2:00 AM.

Tags

None

Referenced Files

	F14079296: D8081.diff
	Fri, Nov 22, 7:41 AM

	Unknown Object (File)
	Sun, Nov 17, 12:20 AM

	Unknown Object (File)
	Thu, Oct 31, 9:40 PM

	Unknown Object (File)
	Thu, Oct 24, 6:38 AM

	Unknown Object (File)
	Oct 15 2024, 3:59 AM

	Unknown Object (File)
	Sep 12 2024, 2:36 PM

	Unknown Object (File)
	Sep 5 2024, 1:03 AM

	Unknown Object (File)
	Sep 2 2024, 9:17 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
talshiri

Commits

rARC7116659289a4: Improve some messaging in `arc which` for autodetection of repositories

Summary

The modern name for the config is "project.name".
Missing parameter in a pht().
When the value is set, but not valid, we gave you a misleading error message.

Test Plan

Ran arc which.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

talshiri added inline comments.Jan 28 2014, 3:03 AM

src/workflow/ArcanistBaseWorkflow.php
1661	This slightly lies though, doesn't it? getProjectID() falls back to fetching project_id

epriestley added inline comments.Jan 28 2014, 3:05 AM

src/workflow/ArcanistBaseWorkflow.php
1661	"project_id" is a deprecated spelling of "project.name"; "project.id" (`.` vs `_`) was never correct, I just neglected to fix it after renaming `project.id` -> `project.name` mid-patch.

talshiri accepted this revision.Jan 28 2014, 3:12 AM

Closed by commit rARC7116659289a4 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistBaseWorkflow.php

17 lines

Diff 18286

View Options

src/workflow/ArcanistBaseWorkflow.php

Improve some messaging in `arc which` for autodetection of repositoriesClosedPublicActions