Page MenuHomePhabricator

Burnup report showing decimals on hover
ClosedPublic

Authored by guywarner on Jan 27 2014, 9:46 PM.
Tags
None
Referenced Files
F14008208: D8080.diff
Tue, Oct 29, 5:34 PM
F13974717: D8080.id18279.diff
Fri, Oct 18, 7:02 AM
F13964754: D8080.diff
Tue, Oct 15, 9:45 PM
Unknown Object (File)
Oct 4 2024, 6:26 PM
Unknown Object (File)
Oct 4 2024, 4:34 PM
Unknown Object (File)
Oct 4 2024, 4:18 AM
Unknown Object (File)
Sep 20 2024, 12:40 PM
Unknown Object (File)
Sep 20 2024, 11:41 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP2721aa272b48: Burnup report showing decimals on hover
Summary

Added yformat to ManiphestReportController. Removed [yy] from the js.
Will pull config.yformat or send []. The old way with [yy] never seemed to worked having config.yformat, also would crash if yformat was in with value

Test Plan

Loadup burn up report, hover over a given date. Number of tasks opened should be an int

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Lints fine locally, seems to work.

$ arc lint
 OKAY  No lint warnings.

I think format() must have taken a list before, the config.yformat || [] seems wrong too (e.g., should just be config.yformat. I'll fix that in th epull.