Page MenuHomePhabricator

Burnup report showing decimals on hover
ClosedPublic

Authored by guywarner on Jan 27 2014, 9:46 PM.
Tags
None
Referenced Files
F13818687: D8080.diff
Fri, Sep 20, 9:31 AM
Unknown Object (File)
Thu, Sep 19, 8:11 AM
Unknown Object (File)
Thu, Sep 19, 8:11 AM
Unknown Object (File)
Thu, Sep 19, 8:11 AM
Unknown Object (File)
Thu, Sep 19, 8:04 AM
Unknown Object (File)
Mon, Sep 9, 2:21 PM
Unknown Object (File)
Tue, Sep 3, 10:34 AM
Unknown Object (File)
Mon, Sep 2, 5:50 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP2721aa272b48: Burnup report showing decimals on hover
Summary

Added yformat to ManiphestReportController. Removed [yy] from the js.
Will pull config.yformat or send []. The old way with [yy] never seemed to worked having config.yformat, also would crash if yformat was in with value

Test Plan

Loadup burn up report, hover over a given date. Number of tasks opened should be an int

Diff Detail

Branch
master
Lint
Lint Skipped
Unit
No Test Coverage

Event Timeline

Lints fine locally, seems to work.

$ arc lint
 OKAY  No lint warnings.

I think format() must have taken a list before, the config.yformat || [] seems wrong too (e.g., should just be config.yformat. I'll fix that in th epull.