Page MenuHomePhabricator

Legalpad - add a view signatures page
ClosedPublic

Authored by btrahan on Jan 17 2014, 12:35 AM.
Tags
None
Referenced Files
F19359767: D7986.id.diff
Dec 26 2025, 9:11 AM
F19157247: D7986.id18067.diff
Dec 13 2025, 10:23 AM
F19081722: D7986.id.diff
Dec 2 2025, 8:08 AM
F19079787: D7986.diff
Dec 1 2025, 10:47 PM
F18852336: D7986.id.diff
Oct 31 2025, 8:02 AM
F18847033: D7986.diff
Oct 29 2025, 10:32 PM
Unknown Object (File)
May 25 2025, 4:40 PM
Unknown Object (File)
May 6 2025, 4:40 AM

Details

Reviewers
epriestley
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP4e6390774fac: Legalpad - add a view signatures page
Summary

...needs to add a LegalpadDocumentSignatureQuery class to get this done, which is also re-deployed everywhere we were issuing raw queries. Ref T3116.

Test Plan

viewed some signatures. Verified color and footer icons showed up how I wanted them to.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley added inline comments.
src/applications/legalpad/controller/LegalpadDocumentSignatureVerificationController.php
24โ€“36

Will $user (i.e., a logged out user) be able to see the signature? I think they won't, so this will break email signatures?

src/applications/legalpad/controller/LegalpadDocumentSignatureVerificationController.php
24โ€“36

ah, nice catch. i'll just issue a raw query with a comment...

btrahan updated this revision to Unknown Object (????).Jan 17 2014, 7:37 PM

fix not logged in case for verifying sigs