...needs to add a LegalpadDocumentSignatureQuery class to get this done, which is also re-deployed everywhere we were issuing raw queries. Ref T3116.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- Restricted Diffusion Commit
rP4e6390774fac: Legalpad - add a view signatures page
viewed some signatures. Verified color and footer icons showed up how I wanted them to.
Diff Detail
Diff Detail
- Branch
- legalpadsigs
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
| src/applications/legalpad/controller/LegalpadDocumentSignatureVerificationController.php | ||
|---|---|---|
| 24–27 | Will $user (i.e., a logged out user) be able to see the signature? I think they won't, so this will break email signatures? | |
| src/applications/legalpad/controller/LegalpadDocumentSignatureVerificationController.php | ||
|---|---|---|
| 24–27 | ah, nice catch. i'll just issue a raw query with a comment... | |