Page MenuHomePhabricator
Differential D7969

Use RemarkupControl in Differential inline comment UI
ClosedPublic
Actions

Authored by epriestley on Jan 14 2014, 10:51 PM.
Tags
None
Referenced Files
F13813636: D7969.id18029.diff
Thu, Sep 19, 12:00 AM
F13813618: D7969.id18031.diff
Wed, Sep 18, 11:56 PM
F13813581: D7969.id18028.diff
Wed, Sep 18, 11:47 PM
Unknown Object (File)
Mon, Sep 16, 1:23 PM
Unknown Object (File)
Fri, Sep 13, 1:49 AM
Unknown Object (File)
Wed, Sep 11, 6:44 PM
Unknown Object (File)
Wed, Sep 4, 9:24 PM
Unknown Object (File)
Sun, Sep 1, 10:57 AM
View All Files
Subscribers
aran
chad

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4317: "Monospace textareas" isn't effective for inline comments
Commits
Restricted Diffusion Commit
rP42d9fa34e21b: Use RemarkupControl in Differential inline comment UI
Summary

Fixes T4317. Update the "inline comment" control to a RemarkupControl. This could maybe use some padding/spacing/design touches eventually but seems OK for the moment.

Test Plan

{F101825}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 14 2014, 10:52 PM
  • Also setUser() to actually pick up monospacing.
chad accepted this revision.Jan 14 2014, 11:02 PM
chad added a comment.Jan 14 2014, 11:14 PM

i will do what I can to make facebook hate this

epriestley added a comment.Jan 14 2014, 11:15 PM

yessss

epriestley closed this revision.Jan 14 2014, 11:15 PM

Closed by commit rP42d9fa34e21b (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
view/
11 lines
infrastructure/
diff/
13 lines
webroot/
rsrc/
css/
application/
differential/
5 lines

Diff 18031

View Options

src/applications/differential/view/DifferentialInlineCommentEditView.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
Phabricator · Built by Phacility