Page MenuHomePhabricator

Use RemarkupControl in Differential inline comment UI
ClosedPublic

Authored by epriestley on Jan 14 2014, 10:51 PM.
Tags
None
Referenced Files
F14655965: D7969.diff
Sat, Jan 11, 7:03 PM
Unknown Object (File)
Mon, Jan 6, 11:38 AM
Unknown Object (File)
Dec 12 2024, 5:20 AM
Unknown Object (File)
Dec 12 2024, 3:38 AM
Unknown Object (File)
Dec 11 2024, 3:10 PM
Unknown Object (File)
Dec 9 2024, 8:28 PM
Unknown Object (File)
Dec 6 2024, 3:28 PM
Unknown Object (File)
Dec 4 2024, 9:45 AM
Subscribers

Details

Summary

Fixes T4317. Update the "inline comment" control to a RemarkupControl. This could maybe use some padding/spacing/design touches eventually but seems OK for the moment.

Test Plan

{F101825}

Diff Detail

Branch
inlinecomment
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 14 2014, 10:52 PM
  • Also setUser() to actually pick up monospacing.

i will do what I can to make facebook hate this