Page MenuHomePhabricator

Use RemarkupControl in Differential inline comment UI
ClosedPublic

Authored by epriestley on Jan 14 2014, 10:51 PM.
Tags
None
Referenced Files
F14027385: D7969.diff
Fri, Nov 8, 7:00 AM
F13987299: D7969.id18028.diff
Mon, Oct 21, 8:38 AM
F13984210: D7969.id18029.diff
Sun, Oct 20, 11:41 AM
Unknown Object (File)
Sep 19 2024, 12:00 AM
Unknown Object (File)
Sep 18 2024, 11:56 PM
Unknown Object (File)
Sep 18 2024, 11:47 PM
Unknown Object (File)
Sep 16 2024, 1:23 PM
Unknown Object (File)
Sep 13 2024, 1:49 AM
Subscribers

Details

Summary

Fixes T4317. Update the "inline comment" control to a RemarkupControl. This could maybe use some padding/spacing/design touches eventually but seems OK for the moment.

Test Plan

{F101825}

Diff Detail

Branch
inlinecomment
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Jan 14 2014, 10:52 PM
  • Also setUser() to actually pick up monospacing.

i will do what I can to make facebook hate this