Workboard - Make the edit icons on the columns actually work
ClosedPublic
Actions

Authored by mikn on Jan 12 2014, 1:58 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T1344: Create the ability to show a Trello style view for projects.

Commits

Restricted Diffusion Commit
rP10ea1dd74900: Workboard - Make the edit icons on the columns actually work

Summary

Made the edit path of the Edit controller work (before only create worked), also added in the link for the cog icon to actually land you on the edit page for the correct column. Some cleanup too. *cough*

Test Plan

Click on gear
Look at fancy title you are about to edit
Change it
Enjoy changed title

Diff Detail

Branch

col_edit

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/project/controller/PhabricatorProjectBoardController.php:43	XHP16	TODO Comment

Unit

Tests Passed

Event Timeline

A couple of minor inlines, this looks good otherwise.

src/applications/project/controller/PhabricatorProjectBoardController.php
46–51	This probably derps for projects with no columns yet, but that's fine.
61	For consistency, include the trailing "/" in this URI. We'll add it automatically if it's omitted, but Phabricator URIs generally end with a "/".
src/applications/project/controller/PhabricatorProjectBoardEditController.php
38–39	Use `requireCapabilities()` to require CAN_EDIT. Add an `if (!$column) { return 404; }` check.
73–78	This should only be for new columns -- editing a column shouldn't change its sequence number.