Page MenuHomePhabricator
Differential D7907

Update Email Address setting page
ClosedPublic
Actions

Authored by chad on Jan 8 2014, 8:33 PM.
Tags
None
Referenced Files
F13272849: D7907.id17898.diff
Thu, May 30, 10:57 PM
F13267404: D7907.diff
Wed, May 29, 3:15 AM
F13252937: D7907.diff
Sat, May 25, 2:13 AM
F13231149: D7907.diff
Tue, May 21, 12:13 AM
F13229138: D7907.id17899.diff
Mon, May 20, 2:40 PM
F13224540: D7907.id17900.diff
Sun, May 19, 9:06 AM
F13185515: D7907.diff
Sat, May 11, 2:58 AM
F13175423: D7907.diff
Wed, May 8, 5:07 AM
View All Files
Subscribers
aran
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP1cb8f0b39383: Update Email Address setting page
Summary

Uses new PHUIObjectBox table hotness.

Test Plan

Add address, make primary, remove.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley accepted this revision.Jan 8 2014, 8:41 PM

The sigil stuff shouldn't be necessary -- since it extends AphrontTagView, it should already have an addSigil() method.

chad updated this revision to Unknown Object (????).Jan 8 2014, 8:42 PM
  • Remove Sigil
chad closed this revision.Jan 8 2014, 8:43 PM

Closed by commit rP1cb8f0b39383 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
settings/
panel/
28 lines
webroot/
rsrc/
css/
phui/
3 lines

Diff 17900

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
Phabricator · Built by Phacility