Page MenuHomePhabricator
Differential D7907

Update Email Address setting page
ClosedPublic
Actions

Authored by chad on Jan 8 2014, 8:33 PM.
Tags
None
Referenced Files
F13175423: D7907.diff
Wed, May 8, 5:07 AM
Unknown Object (File)
Tue, May 7, 5:17 AM
Unknown Object (File)
Fri, May 3, 2:46 AM
Unknown Object (File)
Mon, Apr 29, 2:13 PM
Unknown Object (File)
Wed, Apr 24, 10:02 PM
Unknown Object (File)
Tue, Apr 23, 8:41 AM
Unknown Object (File)
Thu, Apr 11, 7:37 AM
Unknown Object (File)
Apr 5 2024, 3:25 AM
View All Files
Subscribers
aran
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP1cb8f0b39383: Update Email Address setting page
Summary

Uses new PHUIObjectBox table hotness.

Test Plan

Add address, make primary, remove.

Diff Detail

Branch
email-settings
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley accepted this revision.Jan 8 2014, 8:41 PM

The sigil stuff shouldn't be necessary -- since it extends AphrontTagView, it should already have an addSigil() method.

chad updated this revision to Unknown Object (????).Jan 8 2014, 8:42 PM
  • Remove Sigil
chad closed this revision.Jan 8 2014, 8:43 PM

Closed by commit rP1cb8f0b39383 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
settings/
panel/
28 lines
view/
phui/
9 lines
webroot/
rsrc/
css/
phui/
3 lines

Diff 17898

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php

Loading...
View Options

src/view/phui/PHUIButtonView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
Phabricator · Built by Phacility