Page MenuHomePhabricator

Apply "enormous changes" rules to pre-commit content rules too
ClosedPublic

Authored by epriestley on Jan 3 2014, 9:33 PM.
Tags
None
Referenced Files
F13186671: D7887.diff
Sat, May 11, 3:48 AM
Unknown Object (File)
Tue, May 7, 5:40 AM
Unknown Object (File)
Fri, May 3, 4:02 AM
Unknown Object (File)
Thu, May 2, 1:45 AM
Unknown Object (File)
Mon, Apr 29, 7:35 PM
Unknown Object (File)
Mon, Apr 29, 7:35 PM
Unknown Object (File)
Mon, Apr 29, 7:35 PM
Unknown Object (File)
Mon, Apr 29, 3:18 PM
Subscribers

Details

Summary

Fixes T4276. This adds "Change is enormous" to pre-commit content rules so we can, e.g., just reject these and not worry about them elsewhere.

Also, use the same numeric limits across the mechanisms so there's a consistent definition of an "enormous" changeset.

Test Plan
  • Set enormous limit to 15 bytes, pushed some changes, got blocked by a rule.
  • Set it back, pushed OK.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped